Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add as pull request to GPII repo #1

Open
amb26 opened this issue Jun 12, 2015 · 2 comments
Open

Add as pull request to GPII repo #1

amb26 opened this issue Jun 12, 2015 · 2 comments

Comments

@amb26
Copy link

amb26 commented Jun 12, 2015

Hi there Leopold - could you add this as a pull request to https://github.com/GPII/node-gsettings so that we can go through review?

Cheers,
Antranig

@vilnius-leopold
Copy link
Owner

hi antranig! Great that things are moving along. Not sure if I did what you were asking. I forked the https://github.com/GPII/node-gsettings, merged my node-gsettings repo into it and now created the pull request... is that what you were asking for? As you can see I'm a bit noob in this hole fork and pull stuff, so you might have to give me a hand on that!
Once we got this stuff worked out we can talk about the things you commented on the GPI/Linux pull request.
Greets, leo

@amb26
Copy link
Author

amb26 commented Jun 14, 2015

Thanks Leo - this is perfect. Many thanks for producing the pull request, you seem to have done it perfectly. Thanks again for putting in so much good work into this useful library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants