Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider how LIMIT should apply to UNION queries #5

Open
viktorvsk opened this issue Jul 30, 2023 · 0 comments
Open

Consider how LIMIT should apply to UNION queries #5

viktorvsk opened this issue Jul 30, 2023 · 0 comments

Comments

@viktorvsk
Copy link
Owner

Currently if RELAY_CONFIG.max_limit is set to 100 and REQ command is sent by a client with 5 different filters (i.e. ["REQ", "subscription", {...}, {...}, {...}, {...}, {...}] the response in theory will contain 500 records maximum (100 per filter). Also, in case filters have #authors filter, NIP-26 delegation will trigger another UNION to each subquery.

We could limit resulting set, but it could be not clear for clients, so the best and the most obvious solution should be defined and enforced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant