Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In lines per author graphs, sorting of authors is not correct #127

Open
pulkomandy opened this issue Apr 15, 2020 · 3 comments
Open

In lines per author graphs, sorting of authors is not correct #127

pulkomandy opened this issue Apr 15, 2020 · 3 comments

Comments

@pulkomandy
Copy link
Contributor

Authors are sorted by commit count instead of line count in this graph. As a result, the legend is in the same order as the graph below, and in the popup with numbers you can see that the items are not sorted by number of lines as would be expected

@vifactor
Copy link
Owner

I would think of replacing this graph with something smarter as contribution is not only how many lines added, but also how many lines removed. Perhaps, it is worth to remove this plot and plot streamgraph using not number of commits, but modifications_count = lines_added + lines_removed.

Sorting there I would say is less important.

@pulkomandy
Copy link
Contributor Author

pulkomandy commented Apr 15, 2020

Yes, I find this graph not so useful in the current form. Maybe number of "owned" line (as in git blame) would be more interesting, but not as easy to collect. (and that's isue #14 , I knew I got the idea from somewhere)

I'm trying to think of something nice to show added vs removed lines. Maybe a barchart or stacked graph with bars above/below 0. I may experiment with that.

@vifactor
Copy link
Owner

vifactor commented Apr 15, 2020

Maybe number of "owned" line (as in git blame) would be more interesting, but not as easy to collect.

this is technically easy to collect, but extremelly slow. for big repos with thousands of files, it will simply be impossible to wait that long (even if enable multiprocessing and run on all CPU cores).

I'm trying to think of something nice to show added vs removed lines

You may try to implement same graphs as github does when you go to "contributors" stats, I do not know whether it will look good for even 5-7 authors on one plot, though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants