Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl+0 causes a jump to the beginning of the video #1462

Open
alopatindev opened this issue Oct 7, 2024 · 1 comment · May be fixed by #1493
Open

Ctrl+0 causes a jump to the beginning of the video #1462

alopatindev opened this issue Oct 7, 2024 · 1 comment · May be fixed by #1493
Labels
bug Something isn't working

Comments

@alopatindev
Copy link

alopatindev commented Oct 7, 2024

Causes painful UX: if you watch a long video and just expect a normal behavior from Ctrl+0 (which is zooming the page to a normal size), instead it jumps to the beginning and demotivates continuing watching the video, because this requires finding where you were interrupted.

Seems to be there's no mention of such hotkey in the code, there's no such behavior on YouTube and Vimeo, so this appears to be a bug to me.

Reproduction Link: https://www.vidstack.io/player/demo

Doesn't reproduce with <media-player ... key-disabled>.

Thanks for making Vidstack Player anyway! Looks like it's the least buggy and yet most powerful player of those that are currently compatible with p2p-media-loader.

@alopatindev alopatindev added the bug Something isn't working label Oct 7, 2024
@alopatindev alopatindev changed the title Ctrl+0 causes jump to the beginning of the video Ctrl+0 causes a jump to the beginning of the video Oct 7, 2024
@alopatindev alopatindev changed the title Ctrl+0 causes a jump to the beginning of the video Ctrl+0 causes a jump to the beginning of the video Oct 7, 2024
alopatindev added a commit to codonaft/vidstack-player that referenced this issue Nov 1, 2024
alopatindev added a commit to codonaft/vidstack-player that referenced this issue Nov 1, 2024
@alopatindev
Copy link
Author

Ctrl+0 is currently interpreted as 0, here's the fix: #1493

alopatindev added a commit to codonaft/vidstack-player that referenced this issue Nov 1, 2024
alopatindev added a commit to codonaft/vidstack-player that referenced this issue Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant