feat: add class to normalise time control display #8833
Merged
+4
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Time controls continue to cause confusion as they are included by default but hidden by default. e.g. #8534 Adding CSS to display them is not intuitive.
Specific Changes proposed
Changing the default styles would be problematic before a major version. This PR proposes adding an optional
vjs-normalise-time-controls
class a user can add to the player, as an opt in.This will default all time controls to being shown, except when live content is playing. Users would then have to remove the time controls in player options, or with
hide()
ordispose()
.Requirements Checklist
npm run docs:api
to error