Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: registering new player component #8932

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

victordidenko
Copy link

Do not allow to register new Player component, if any instance of the current component still exists.

Fixes #8925

Do not allow to register new Player component, if any instance of the current component still exists.

Fixes videojs#8925
Copy link

welcome bot commented Dec 1, 2024

💖 Thanks for opening this pull request! 💖

Things that will help get your PR across the finish line:

  • Run npm run lint -- --errors locally to catch formatting errors earlier.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible incorrect logic with registering new Player
2 participants