Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player.currentSource return type missing src property #8923

Open
TomBennettLloyd opened this issue Nov 20, 2024 · 1 comment
Open

Player.currentSource return type missing src property #8923

TomBennettLloyd opened this issue Nov 20, 2024 · 1 comment
Labels
needs: triage This issue needs to be reviewed

Comments

@TomBennettLloyd
Copy link

TomBennettLloyd commented Nov 20, 2024

Description

The return type for Player.currentSource() should include the src property with the string value for the source url.

This is even how it is described in the documentation for the Tech class, however, the type for the Tech class doesn't actually include this property so trying to access it results in a type error.

Steps to reproduce

  1. import videojs from the npm module
  2. initialise a player
  3. Call Player.currentSource().src in a project with typescript enabled
  4. run type checking and observe the type error

Errors

No response

What version of Video.js are you using?

8.19.1

Video.js plugins used.

No response

What browser(s) including version(s) does this occur with?

any

What OS(es) and version(s) does this occur with?

any

@TomBennettLloyd TomBennettLloyd added the needs: triage This issue needs to be reviewed label Nov 20, 2024
Copy link

welcome bot commented Nov 20, 2024

👋 Thanks for opening your first issue here! 👋

If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.
To help make it easier for us to investigate your issue, please follow the contributing guidelines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: triage This issue needs to be reviewed
Projects
None yet
Development

No branches or pull requests

1 participant