Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconnect the client if the connection was lost #11

Closed
pkronstrom opened this issue Jan 9, 2019 · 2 comments
Closed

Reconnect the client if the connection was lost #11

pkronstrom opened this issue Jan 9, 2019 · 2 comments

Comments

@pkronstrom
Copy link
Contributor

pkronstrom commented Jan 9, 2019

Currently, the dbus-listener.js does not reconnect, if the connection to the system dbus was lost for some reason. This will cause the victron energy nodes to hang in case the dbus service is restarted (or dbus service started after node-red, for example).

See
sbender9/signalk-venus-plugin#7
and
https://github.com/sbender9/signalk-venus-plugin/blob/master/dbus-listener.js

@mpvader
Copy link
Contributor

mpvader commented Jan 9, 2019

Note that; as in real life your code will run on the venus device; this will never happen.

There is no other oroject on Vneus OS that survives a dbus reset.

Instead; we have a watchdog that restarts the full venus device/os upon a dbus-daemon crash/reset

@wollew
Copy link

wollew commented Jun 5, 2023

Note that; as in real life your code will run on the venus device; this will never happen.

I know this is an old issue, but I just ran into this issue. Your statement is only true if you're using this on the Venus device itself, if you deploy them to an external node-red instance then this can and will happen, a simple reboot of the Venus device is enough to trigger the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants