From bb62c8e19b65be99b66cbc54987ee7239b53a2dd Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?V=C3=ADctor=20S=C3=A1nchez?= <victor.s.olaya@gmail.com>
Date: Sat, 21 Nov 2020 18:26:59 +0100
Subject: [PATCH] Readonly (#17)

- Added functionality for the no action readme tags
Co-authored-by: Fernando Bo Gimenez <fernando.bo21@gmail.com>
---
 .../ControlManifest.Input.xml                 |  8 +--
 .../MultiselectRecords.tsx                    | 63 +++++++++++--------
 MultiselectRecordsEntity/index.ts             |  2 +-
 README.md                                     |  2 +-
 4 files changed, 42 insertions(+), 33 deletions(-)

diff --git a/MultiselectRecordsEntity/ControlManifest.Input.xml b/MultiselectRecordsEntity/ControlManifest.Input.xml
index a84c660..3af8890 100644
--- a/MultiselectRecordsEntity/ControlManifest.Input.xml
+++ b/MultiselectRecordsEntity/ControlManifest.Input.xml
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="utf-8" ?>
 <manifest>
-  <control namespace="VictorSanchez" constructor="MultiselectRecordsEntity" version="0.0.23" display-name-key="Multiselect Records Entity" description-key="Multiple selector for several records and insert in a string" control-type="standard">
+  <control namespace="VictorSanchez" constructor="MultiselectRecordsEntity" version="0.0.24" display-name-key="Multiselect Records Entity" description-key="Multiple selector for several records and insert in a string" control-type="standard">
     <!-- property node identifies a specific, configurable piece of data that the control expects from CDS -->
      <type-group name="textareas">
         <type>SingleLine.Text</type>
@@ -22,6 +22,7 @@
     </property>
 
     <property name="openFormOptions" display-name-key="How do you want to open the form?" description-key="How do you want to open the form when you click the record?" of-type="Enum" usage="input" required="true">
+      <value name="noAction" display-name-key="No action" description-key="Disable the action">No action</value>
       <value name="popup" display-name-key="As a popup" description-key="In a pop up">Pop up</value>
       <value name="sameWindow" display-name-key="In the same window" description-key="In the same window">In the same window</value>
       <value name="newWindow" display-name-key="In a new window" description-key="In a new window">In a new window</value>
@@ -36,8 +37,7 @@
       <value name="false" display-name-key="False" description-key="false">False</value>
     </property>
     <property name="recordsToBeReturned" display-name-key="Amount of records to be shown as maximum" description-key="Set the number of records to be shown in the list as maximum. By default 50" of-type="Whole.None" usage="input" required="false" />
-
-    
+   
     <resources>
       <code path="index.ts" order="1"/>
     </resources>
@@ -46,4 +46,4 @@
       <uses-feature name="WebAPI" required="true" />
     </feature-usage>
   </control>
-</manifest>
\ No newline at end of file
+</manifest>
diff --git a/MultiselectRecordsEntity/MultiselectRecords.tsx b/MultiselectRecordsEntity/MultiselectRecords.tsx
index 1866383..22d8037 100644
--- a/MultiselectRecordsEntity/MultiselectRecords.tsx
+++ b/MultiselectRecordsEntity/MultiselectRecords.tsx
@@ -331,35 +331,44 @@ const getRecordsFromTextField = async () => {
           Number.parseFloat(version[0] + "." + version[1]) >= 9.1 &&
           Number.parseFloat(version[2] + "." + version[3]) >= 0.15631
         ) {
-            
-           if(props.openWindow.toLowerCase() == "in a new window") {
-            (Xrm.Navigation as any).openForm({
-                    entityName: logicalName,
-                    entityId: id,
-                    openInNewWindow: true
-                  });
-            }else if(props.openWindow.toLowerCase() == "in the same window") {
-                (Xrm.Navigation as any).openForm({
-                    entityName: logicalName,
-                    entityId: id,
-                    openInNewWindow: false
-                  });
-            } else {
-                (Xrm.Navigation as any).navigateTo(
-                    {
+            switch (props.openWindow.toLowerCase())
+            {
+                case "no action":
+                    break;
+                case "in a new window":
+                    (Xrm.Navigation as any).openForm({
+                        entityName: logicalName,
+                        entityId: id,
+                        openInNewWindow: true
+                        });
+                break;
+                case "in the same window":
+                    (Xrm.Navigation as any).openForm({
+                        entityName: logicalName,
+                        entityId: id,
+                        openInNewWindow: false
+                        });
+                    break;
+                default:
+                case "in a pop up":
+                    (Xrm.Navigation as any).navigateTo(
+                        {
+                        entityName: logicalName,
+                        pageType: "entityrecord",
+                        formType: 2,
+                        entityId: id,
+                        },
+                        { target: 2, position: 1, width: { value: 80, unit: "%" } },
+                    );
+                    break;
+                }
+        } else {
+            if(props.openWindow.toLowerCase() != "no action") {
+                Xrm.Navigation.openForm({
                     entityName: logicalName,
-                    pageType: "entityrecord",
-                    formType: 2,
                     entityId: id,
-                    },
-                    { target: 2, position: 1, width: { value: 80, unit: "%" } },
-                );
+                    });
             }
-        } else {
-          Xrm.Navigation.openForm({
-            entityName: logicalName,
-            entityId: id,
-          });
         }
     } 
 
@@ -567,4 +576,4 @@ const getRecordsFromTextField = async () => {
         );
 }
 
-export default MultiselectRecords;
\ No newline at end of file
+export default MultiselectRecords;
diff --git a/MultiselectRecordsEntity/index.ts b/MultiselectRecordsEntity/index.ts
index 5f9ed52..6d1ba75 100644
--- a/MultiselectRecordsEntity/index.ts
+++ b/MultiselectRecordsEntity/index.ts
@@ -204,4 +204,4 @@ export class MultiselectRecordsEntity implements ComponentFramework.StandardCont
 		// Add code to cleanup control if necessary
 		ReactDOM.unmountComponentAtNode(this._container);
 	}
-}
\ No newline at end of file
+}
diff --git a/README.md b/README.md
index b81b84a..ab75f89 100644
--- a/README.md
+++ b/README.md
@@ -67,7 +67,7 @@ What have been the improvements with the previous version?
 
 8. Header Visible (required)-> Set if the header will be visible in the list displayed.
 
-9. Open Form Options (required) -> This allows you to choose how to open the record when you perform an onClick. Options are: Popup, New Window, Same Window.
+9. Open Form Options (required) -> This allows you to choose how to open the record when you perform an onClick. Options are: Popup, New Window, Same Window or No Action.
 
 10. Populated Field Visible (required)-> Set if the field that gets populated will be visible. **NOTE: As now it is a JSON I would suggest to always set is as False. (It is the first option to appear when you select the dropdown)**