Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile calls for Makefile.common #38

Closed
soamaven opened this issue Jul 15, 2016 · 4 comments
Closed

Makefile calls for Makefile.common #38

soamaven opened this issue Jul 15, 2016 · 4 comments

Comments

@soamaven
Copy link

Makefile calls for Makefile.common which does not exist in the repo. What was intended to be in there? The parts of Makefile.old below the "do not change line" I will guess and report back with results.
@JamesBurch
Copy link

Hello,

Did you solve this problem?

Cheers, J

@soamaven
Copy link
Author

Not really a solution, but I just checked-out the commit before the new Makefile scheme was added. The old Makefile worked just fine for me. I will see if I can make the Makefile.common scheme work and put in a PR... I'm not sure @victorliu intended to leave it out or not.

@soamaven
Copy link
Author

I made PR #39 to resolve this issue. It should compile, but I get a lot of warnings about unsigned int comparisons... It looks like newer code, so the older core should be fine

@JamesBurch
Copy link

Thanks a ton, I believe I may have successfully compiled now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@victorliu @soamaven @JamesBurch