Don't create adjoints for integral type variables #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| llvm::SmallVectorImpl<Stmt*>* block /*=nullptr*/) { | ||
| DeclContext* originalFnDC = nullptr; | ||
| if (originalFD) | ||
| originalFnDC = const_cast<DeclContext*>(originalFD->getDeclContext()); |
There was a problem hiding this comment.
warning: do not use const_cast [cppcoreguidelines-pro-type-const-cast]
originalFnDC = const_cast<DeclContext*>(originalFD->getDeclContext());
^
PetroZarytskyi
force-pushed
the
int-diff
branch
from
c5194e2
to
c993a64
Compare
PetroZarytskyi
force-pushed
the
int-diff
branch
from
dc21b9f
to
9e343b5
Compare
PetroZarytskyi
force-pushed
the
int-diff
branch
5 times, most recently
from
20b6dfc
to
2864c56
Compare
PetroZarytskyi
force-pushed
the
int-diff
branch
8 times, most recently
from
433363d
to
63d07c5
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #864 +/- ##
==========================================
- Coverage 94.82% 94.58% -0.25%
==========================================
Files 52 51 -1
Lines 7708 7678 -30
==========================================
- Hits 7309 7262 -47
- Misses 399 416 +17
... and 10 files with indirect coverage changes
|
… start using overloads in error estimation
|
clang-tidy review says "All clean, LGTM! 👍" |
|
Since this is largely backward incompatible change, can you open this PR against the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes adjoints for integral types in the reverse mode. This is done because integers are not differentiable in the traditional mathematical sense. Such behavior is consistent with other AD tools like Tapenade and Enzyme. Let's consider an example to see the difference in behavior
This is essentially a floor function so mathematically the derivative should be 0. However, Clad master produces 1. Let's compare the derivatives on master and in this PR.
master:
this PR: