-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kokkos-aware Clad #783
base: master
Are you sure you want to change the base?
Kokkos-aware Clad #783
Changes from all commits
082bb20
9b9612e
9284719
65557a9
322ca21
02dd2ce
7e9c540
2cd5231
db086a5
ef1d117
43fa4d6
092f425
1eb525e
91ec308
f87ccd2
ee88c2e
1118bbe
3fe3122
d6c4633
814e46d
aef1422
230baba
f5b2f4b
09956bc
b7f2d71
09d3dec
327c88a
ddd5763
d01770d
36aec0a
281fb5a
06f4ae0
6ff32fa
fa7f261
fe14c82
0cbb811
6a7bf98
7e82114
f80f4a5
aa6a104
f0448e5
492536d
db084ee
1bf65b1
6ee3054
c80fc4e
4d0050f
a9c0b17
8d8548c
c023697
b9a7a76
09e1211
b25d91c
6c62817
96eaaa5
ce5e8af
a450d90
e45f6d3
b6724da
7d45a90
bd0b9ca
027dfe6
5d79b2c
845a1b3
14342cb
2bb7bc9
1a5193b
21af8c1
0fa0dc0
8a831e9
630538c
0239a5a
1b9dead
816cfad
3a585dd
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -153,6 +153,11 @@ namespace clad { | |||||
clang::DeclContext* GetOutermostDC(clang::Sema& semaRef, | ||||||
clang::DeclContext* DC); | ||||||
|
||||||
clang::Expr* GetUnresolvedLookup(clang::Sema& semaRef, | ||||||
clang::ASTContext& C, | ||||||
std::string NS, | ||||||
std::string FN); | ||||||
|
||||||
/// Creates a `StringLiteral` node to represent string literal | ||||||
/// "`str`". | ||||||
/// | ||||||
|
@@ -174,6 +179,22 @@ namespace clad { | |||||
/// otherwise returns false. | ||||||
bool HasAnyReferenceOrPointerArgument(const clang::FunctionDecl* FD); | ||||||
|
||||||
/// Returns true if `constructedTypeName` is a string describing Kokkos::TeamPolicy type. | ||||||
bool IsKokkosTeamPolicy(const std::string constructedTypeName); | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. warning: parameter 'constructedTypeName' is const-qualified in the function declaration; const-qualification of parameters only has an effect in function definitions [readability-avoid-const-params-in-decls]
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Perhaps |
||||||
|
||||||
/// Returns true if `constructedTypeName` is a string describing Kokkos::TeamThreadRange, | ||||||
/// Kokkos::ThreadVectorRange, or Kokkos::TeamVectorRange type. | ||||||
bool IsKokkosRange(const std::string constructedTypeName); | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. warning: parameter 'constructedTypeName' is const-qualified in the function declaration; const-qualification of parameters only has an effect in function definitions [readability-avoid-const-params-in-decls]
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should pass |
||||||
|
||||||
/// Returns true if `constructedTypeName` is a string describing Kokkos::Member type. | ||||||
bool IsKokkosMember(const std::string constructedTypeName); | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. warning: parameter 'constructedTypeName' is const-qualified in the function declaration; const-qualification of parameters only has an effect in function definitions [readability-avoid-const-params-in-decls]
Suggested change
|
||||||
|
||||||
/// Returns true if `constructedTypeName` is a string describing Kokkos::View type. | ||||||
bool IsKokkosView(const std::string constructedTypeName); | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. warning: parameter 'constructedTypeName' is const-qualified in the function declaration; const-qualification of parameters only has an effect in function definitions [readability-avoid-const-params-in-decls]
Suggested change
|
||||||
|
||||||
/// Returns true if `T` is a Kokkos::View type. | ||||||
bool IsKokkosView(clang::QualType T); | ||||||
|
||||||
/// Returns true if `T` is a reference, pointer or array type. | ||||||
/// | ||||||
/// \note Please note that this function returns true for array types as | ||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ASTContext
can be obtained throughSema
. We don't need to pass both of them to a function.