Lambda support in the reverse mode #1126

gojakuch · 2024-10-29T21:41:16Z

Potentially fixes: #1054

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 10 out of 21. Check the log or trigger a new build to see more.

github-actions · 2024-11-01T18:59:24Z

include/clad/Differentiator/Compatibility.h

@@ -403,6 +403,16 @@ getConstantArrayType(const ASTContext& Ctx, QualType EltTy,
   #define CLAD_COMPAT_CLANG15_Declarator_DeclarationAttrs_ExtraParam clang::ParsedAttributesView::none(),
 #endif

+#if CLANG_VERSION_MAJOR > 12
+#define CLAD_COMPAT_CXXRecordDecl_CreateLambda_DependencyKind(                 \


warning: function-like macro 'CLAD_COMPAT_CXXRecordDecl_CreateLambda_DependencyKind' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage]

#define CLAD_COMPAT_CXXRecordDecl_CreateLambda_DependencyKind( \ ^

github-actions · 2024-11-01T18:59:24Z

lib/Differentiator/ReverseModeVisitor.cpp

+  ReverseModeVisitor::diffLambdaCXXRecordDecl(const CXXRecordDecl* Original) {
+    // Create a new Lambda CXXRecordDecl that is going to represent a pullback
+    CXXRecordDecl* Cloned = CXXRecordDecl::CreateLambda(
+        m_Context, const_cast<DeclContext*>(Original->getDeclContext()),


warning: do not use const_cast [cppcoreguidelines-pro-type-const-cast]

m_Context, const_cast<DeclContext*>(Original->getDeclContext()), ^

github-actions · 2024-11-01T18:59:25Z

lib/Differentiator/ReverseModeVisitor.cpp

+
+    // Create operator() as a pullback
+    for (auto* Method : Original->methods()) {
+      if (CXXMethodDecl* OriginalOpCall = dyn_cast<CXXMethodDecl>(Method)) {


warning: use auto when initializing with a template cast to avoid duplicating the type name [modernize-use-auto]

Suggested change

if (CXXMethodDecl* OriginalOpCall = dyn_cast<CXXMethodDecl>(Method)) {

if (auto* OriginalOpCall = dyn_cast<CXXMethodDecl>(Method)) {

github-actions · 2024-11-01T18:59:25Z

lib/Differentiator/ReverseModeVisitor.cpp

+    std::vector<Expr *> children_Exp;
+    std::vector<Expr *> children_Exp_dx;
+
+    for (auto children : children_iterator_range) {


warning: 'auto children' can be declared as 'const auto *children' [llvm-qualified-auto]

Suggested change

for (auto children : children_iterator_range) {

for (const auto *children : children_iterator_range) {

github-actions · 2024-11-01T18:59:25Z

lib/Differentiator/ReverseModeVisitor.cpp

+
+    for (auto children : children_iterator_range) {
+      // auto children_expr = const_cast<clang::Expr*>(dyn_cast<clang::Expr>(children));
+      auto children_expr = dyn_cast<clang::Expr>(children);


warning: 'auto children_expr' can be declared as 'const auto *children_expr' [llvm-qualified-auto]

Suggested change

auto children_expr = dyn_cast<clang::Expr>(children);

const auto *children_expr = dyn_cast<clang::Expr>(children);

github-actions · 2024-11-01T18:59:25Z

lib/Differentiator/ReverseModeVisitor.cpp

+    // ============== CAP
+
+    // FIXME: ideally, we need to create a reverse_forw lambda and not copy the original one for the forward pass.
+    auto forwardLambdaClass = LE->getLambdaClass();


warning: 'auto forwardLambdaClass' can be declared as 'auto *forwardLambdaClass' [llvm-qualified-auto]

Suggested change

auto forwardLambdaClass = LE->getLambdaClass();

auto *forwardLambdaClass = LE->getLambdaClass();

github-actions · 2024-11-01T18:59:25Z

lib/Differentiator/ReverseModeVisitor.cpp

+                            LE->getCaptureDefaultLoc(),
+                            LE->hasExplicitParameters(),
+                            LE->hasExplicitResultType(),
+                            true);


warning: too many arguments to function call, expected 7, have 8 [clang-diagnostic-error]

true); ^

Additional context

llvm/include/clang/Sema/Sema.h:7176: 'buildLambdaScope' declared here

void buildLambdaScope(sema::LambdaScopeInfo *LSI, CXXMethodDecl *CallOperator, ^

github-actions · 2024-11-01T18:59:25Z

lib/Differentiator/ReverseModeVisitor.cpp

+                            LE->hasExplicitResultType(),
+                            true);
+
+    auto forwardLE = LambdaExpr::Create(m_Context,


warning: 'auto forwardLE' can be declared as 'auto *forwardLE' [llvm-qualified-auto]

Suggested change

auto forwardLE = LambdaExpr::Create(m_Context,

auto *forwardLE = LambdaExpr::Create(m_Context,

github-actions · 2024-11-01T18:59:25Z

lib/Differentiator/ReverseModeVisitor.cpp

+
+      std::vector<LambdaCapture> children_LC_Exp_dx;
+
+      for (auto children_expr : children_Exp_dx) {


warning: 'auto children_expr' can be declared as 'auto *children_expr' [llvm-qualified-auto]

Suggested change

for (auto children_expr : children_Exp_dx) {

for (auto *children_expr : children_Exp_dx) {

github-actions · 2024-11-01T18:59:25Z

lib/Differentiator/ReverseModeVisitor.cpp

+      for (auto children_expr : children_Exp_dx) {
+        if(isa<CXXConstructExpr>(children_expr)) {
+
+          auto tmp = dyn_cast<CXXConstructExpr>(children_expr)->getArg(0)->IgnoreImpCasts();


warning: 'auto tmp' can be declared as 'auto *tmp' [llvm-qualified-auto]

Suggested change

auto tmp = dyn_cast<CXXConstructExpr>(children_expr)->getArg(0)->IgnoreImpCasts();

auto *tmp = dyn_cast<CXXConstructExpr>(children_expr)->getArg(0)->IgnoreImpCasts();

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 10 out of 11. Check the log or trigger a new build to see more.

github-actions · 2024-11-09T15:57:45Z

lib/Differentiator/ReverseModeVisitor.cpp

+          auto tmp = dyn_cast<CXXConstructExpr>(children_expr)->getArg(0)->IgnoreImpCasts();
+
+          if (isa<DeclRefExpr>(tmp)) {
+            auto VD = dyn_cast<VarDecl>(dyn_cast<DeclRefExpr>(tmp)->getDecl());


warning: 'auto VD' can be declared as 'auto *VD' [llvm-qualified-auto]

Suggested change

auto VD = dyn_cast<VarDecl>(dyn_cast<DeclRefExpr>(tmp)->getDecl());

auto *VD = dyn_cast<VarDecl>(dyn_cast<DeclRefExpr>(tmp)->getDecl());

github-actions · 2024-11-09T15:57:45Z

lib/Differentiator/ReverseModeVisitor.cpp

+
+          if (isa<DeclRefExpr>(tmp)) {
+            auto VD = dyn_cast<VarDecl>(dyn_cast<DeclRefExpr>(tmp)->getDecl());
+            children_LC_Exp_dx.push_back(LambdaCapture(SourceLocation(), true, LambdaCaptureKind::LCK_ByRef, VD));


warning: use emplace_back instead of push_back [modernize-use-emplace]

Suggested change

children_LC_Exp_dx.push_back(LambdaCapture(SourceLocation(), true, LambdaCaptureKind::LCK_ByRef, VD));

children_LC_Exp_dx.emplace_back(SourceLocation(), true, LambdaCaptureKind::LCK_ByRef, VD);

github-actions · 2024-11-09T15:57:45Z

lib/Differentiator/ReverseModeVisitor.cpp

+            children_LC_Exp_dx.push_back(LambdaCapture(SourceLocation(), true, LambdaCaptureKind::LCK_ByRef, VD));
+          }
+          if(isa<ParenExpr>(tmp)) {
+            auto PE = dyn_cast<ParenExpr>(tmp);


warning: 'auto PE' can be declared as 'auto *PE' [llvm-qualified-auto]

Suggested change

auto PE = dyn_cast<ParenExpr>(tmp);

auto *PE = dyn_cast<ParenExpr>(tmp);

github-actions · 2024-11-09T15:57:45Z

lib/Differentiator/ReverseModeVisitor.cpp

+          }
+          if(isa<ParenExpr>(tmp)) {
+            auto PE = dyn_cast<ParenExpr>(tmp);
+            auto OCE = dyn_cast<CXXOperatorCallExpr>(PE->getSubExpr());


warning: 'auto OCE' can be declared as 'auto *OCE' [llvm-qualified-auto]

Suggested change

auto OCE = dyn_cast<CXXOperatorCallExpr>(PE->getSubExpr());

auto *OCE = dyn_cast<CXXOperatorCallExpr>(PE->getSubExpr());

github-actions · 2024-11-09T15:57:45Z

lib/Differentiator/ReverseModeVisitor.cpp

+            auto PE = dyn_cast<ParenExpr>(tmp);
+            auto OCE = dyn_cast<CXXOperatorCallExpr>(PE->getSubExpr());
+
+            auto VD = dyn_cast<VarDecl>(dyn_cast<DeclRefExpr>(OCE->getArg(0))->getDecl());


warning: 'auto VD' can be declared as 'auto *VD' [llvm-qualified-auto]

Suggested change

auto VD = dyn_cast<VarDecl>(dyn_cast<DeclRefExpr>(OCE->getArg(0))->getDecl());

auto *VD = dyn_cast<VarDecl>(dyn_cast<DeclRefExpr>(OCE->getArg(0))->getDecl());

github-actions · 2024-11-09T15:57:46Z

lib/Differentiator/ReverseModeVisitor.cpp

+            auto OCE = dyn_cast<CXXOperatorCallExpr>(PE->getSubExpr());
+
+            auto VD = dyn_cast<VarDecl>(dyn_cast<DeclRefExpr>(OCE->getArg(0))->getDecl());
+            children_LC_Exp_dx.push_back(LambdaCapture(SourceLocation(), true, LambdaCaptureKind::LCK_ByRef, VD));


warning: use emplace_back instead of push_back [modernize-use-emplace]

Suggested change

children_LC_Exp_dx.push_back(LambdaCapture(SourceLocation(), true, LambdaCaptureKind::LCK_ByRef, VD));

children_LC_Exp_dx.emplace_back(SourceLocation(), true, LambdaCaptureKind::LCK_ByRef, VD);

github-actions · 2024-11-09T15:57:46Z

lib/Differentiator/ReverseModeVisitor.cpp

+          }
+        }
+        if (isa<DeclRefExpr>(children_expr)) {
+            auto VD = dyn_cast<VarDecl>(dyn_cast<DeclRefExpr>(children_expr)->getDecl());


warning: 'auto VD' can be declared as 'auto *VD' [llvm-qualified-auto]

Suggested change

auto VD = dyn_cast<VarDecl>(dyn_cast<DeclRefExpr>(children_expr)->getDecl());

auto *VD = dyn_cast<VarDecl>(dyn_cast<DeclRefExpr>(children_expr)->getDecl());

github-actions · 2024-11-09T15:57:46Z

lib/Differentiator/ReverseModeVisitor.cpp

+        }
+        if (isa<DeclRefExpr>(children_expr)) {
+            auto VD = dyn_cast<VarDecl>(dyn_cast<DeclRefExpr>(children_expr)->getDecl());
+            children_LC_Exp_dx.push_back(LambdaCapture(SourceLocation(), true, LambdaCaptureKind::LCK_ByRef, VD));


warning: use emplace_back instead of push_back [modernize-use-emplace]

Suggested change

children_LC_Exp_dx.push_back(LambdaCapture(SourceLocation(), true, LambdaCaptureKind::LCK_ByRef, VD));

children_LC_Exp_dx.emplace_back(SourceLocation(), true, LambdaCaptureKind::LCK_ByRef, VD);

github-actions · 2024-11-09T15:57:46Z

lib/Differentiator/ReverseModeVisitor.cpp

+                              LE->getCaptureDefaultLoc(),
+                              LE->hasExplicitParameters(),
+                              LE->hasExplicitResultType(),
+                              true);


warning: too many arguments to function call, expected 7, have 8 [clang-diagnostic-error]

true); ^

Additional context

llvm/include/clang/Sema/Sema.h:7176: 'buildLambdaScope' declared here

void buildLambdaScope(sema::LambdaScopeInfo *LSI, CXXMethodDecl *CallOperator, ^

github-actions · 2024-11-09T15:57:46Z

lib/Differentiator/ReverseModeVisitor.cpp

      // We do not need to create result arg for arguments passed by reference
      // because the derivatives of arguments passed by reference are directly
      // modified by the derived callee function.
-      if (utils::IsReferenceOrPointerArg(arg) ||
+      if (utils::IsReferenceOrPointerArg(arg)||
          !m_DiffReq.shouldHaveAdjoint(PVD)) {


warning: repeated branch in conditional chain [bugprone-branch-clone]

!m_DiffReq.shouldHaveAdjoint(PVD)) { ^

Additional context

lib/Differentiator/ReverseModeVisitor.cpp:2191: end of the original

} else if (isArgLambda) { ^

lib/Differentiator/ReverseModeVisitor.cpp:2191: clone 1 starts here

} else if (isArgLambda) { ^

gojakuch force-pushed the lambda-support-reverse branch from fac23c9 to 1ca617c Compare November 1, 2024 18:47

github-actions bot reviewed Nov 1, 2024

View reviewed changes

gojakuch added 3 commits November 9, 2024 16:35

Proper differentiation of lambdas (no captures) & code cleanup

111dff3

tmp + dbg

ad6809b

half-progress with actual captures and fixing crashes

5cb158c

gojakuch force-pushed the lambda-support-reverse branch from 1ca617c to 5cb158c Compare November 9, 2024 15:45

github-actions bot reviewed Nov 9, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Lambda support in the reverse mode #1126

Lambda support in the reverse mode #1126

gojakuch commented Oct 29, 2024 •

edited

Loading

github-actions bot left a comment

github-actions bot Nov 1, 2024

github-actions bot Nov 1, 2024

github-actions bot Nov 1, 2024

github-actions bot Nov 1, 2024

github-actions bot Nov 1, 2024

github-actions bot Nov 1, 2024

github-actions bot Nov 1, 2024

github-actions bot Nov 1, 2024

github-actions bot Nov 1, 2024

github-actions bot Nov 1, 2024

github-actions bot left a comment

github-actions bot Nov 9, 2024

github-actions bot Nov 9, 2024

github-actions bot Nov 9, 2024

github-actions bot Nov 9, 2024

github-actions bot Nov 9, 2024

github-actions bot Nov 9, 2024

github-actions bot Nov 9, 2024

github-actions bot Nov 9, 2024

github-actions bot Nov 9, 2024

github-actions bot Nov 9, 2024

	if (CXXMethodDecl* OriginalOpCall = dyn_cast<CXXMethodDecl>(Method)) {
	if (auto* OriginalOpCall = dyn_cast<CXXMethodDecl>(Method)) {

	for (auto children : children_iterator_range) {
	for (const auto *children : children_iterator_range) {

	auto children_expr = dyn_cast<clang::Expr>(children);
	const auto *children_expr = dyn_cast<clang::Expr>(children);

	auto forwardLambdaClass = LE->getLambdaClass();
	auto *forwardLambdaClass = LE->getLambdaClass();

	auto forwardLE = LambdaExpr::Create(m_Context,
	auto *forwardLE = LambdaExpr::Create(m_Context,


		std::vector<LambdaCapture> children_LC_Exp_dx;

		for (auto children_expr : children_Exp_dx) {

	for (auto children_expr : children_Exp_dx) {
	for (auto *children_expr : children_Exp_dx) {

	auto tmp = dyn_cast<CXXConstructExpr>(children_expr)->getArg(0)->IgnoreImpCasts();
	auto *tmp = dyn_cast<CXXConstructExpr>(children_expr)->getArg(0)->IgnoreImpCasts();

	auto VD = dyn_cast<VarDecl>(dyn_cast<DeclRefExpr>(tmp)->getDecl());
	auto *VD = dyn_cast<VarDecl>(dyn_cast<DeclRefExpr>(tmp)->getDecl());

	children_LC_Exp_dx.push_back(LambdaCapture(SourceLocation(), true, LambdaCaptureKind::LCK_ByRef, VD));
	children_LC_Exp_dx.emplace_back(SourceLocation(), true, LambdaCaptureKind::LCK_ByRef, VD);

	auto PE = dyn_cast<ParenExpr>(tmp);
	auto *PE = dyn_cast<ParenExpr>(tmp);

	auto OCE = dyn_cast<CXXOperatorCallExpr>(PE->getSubExpr());
	auto *OCE = dyn_cast<CXXOperatorCallExpr>(PE->getSubExpr());

Lambda support in the reverse mode #1126

Are you sure you want to change the base?

Lambda support in the reverse mode #1126

Conversation

gojakuch commented Oct 29, 2024 • edited Loading

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Nov 1, 2024

Choose a reason for hiding this comment

github-actions bot Nov 1, 2024

Choose a reason for hiding this comment

github-actions bot Nov 1, 2024

Choose a reason for hiding this comment

github-actions bot Nov 1, 2024

Choose a reason for hiding this comment

github-actions bot Nov 1, 2024

Choose a reason for hiding this comment

github-actions bot Nov 1, 2024

Choose a reason for hiding this comment

github-actions bot Nov 1, 2024

Choose a reason for hiding this comment

github-actions bot Nov 1, 2024

Choose a reason for hiding this comment

github-actions bot Nov 1, 2024

Choose a reason for hiding this comment

github-actions bot Nov 1, 2024

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Nov 9, 2024

Choose a reason for hiding this comment

github-actions bot Nov 9, 2024

Choose a reason for hiding this comment

github-actions bot Nov 9, 2024

Choose a reason for hiding this comment

github-actions bot Nov 9, 2024

Choose a reason for hiding this comment

github-actions bot Nov 9, 2024

Choose a reason for hiding this comment

github-actions bot Nov 9, 2024

Choose a reason for hiding this comment

github-actions bot Nov 9, 2024

Choose a reason for hiding this comment

github-actions bot Nov 9, 2024

Choose a reason for hiding this comment

github-actions bot Nov 9, 2024

Choose a reason for hiding this comment

github-actions bot Nov 9, 2024

Choose a reason for hiding this comment

gojakuch commented Oct 29, 2024 •

edited

Loading