Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HuC6280 Mednafen core support #33

Open
DeltaRazero opened this issue Jan 9, 2018 · 3 comments
Open

HuC6280 Mednafen core support #33

DeltaRazero opened this issue Jan 9, 2018 · 3 comments

Comments

@DeltaRazero
Copy link

First off I'd like to apologize since I wasn't sure if I should request this here since ValleyBell is already busy with the libvgm rewrite.

I was wondering if HuC6280 / HuWSG could get the Mednafen soundcore added as to my research it seems to be the most accurate soundcore for this.
Also seeing as vsu.c uses the Mednafen core for sound emulation, I think it is no strange code hopefully.

Not necessary, but the HuC6280 actually has a revision that was meant to fix some issues with sound, which is called HuC6280A. Within Mednafen's soundcode these are mentioned in PCE_PSG.cpp as well. Support for this would be nice, but not necessary as I said.

@ValleyBell
Copy link
Contributor

TBH it's very unlikely that I add another core to VGMPlay.* Adding stuff to libvgm is just a lot easier.

btw, from a quick look, the HuC6280A sound fix is just a DC offset removal. (I usually enforce this in VGMPlay/libvgm.)

*But I take pull requests.

@DeltaRazero
Copy link
Author

DeltaRazero commented Jan 12, 2018

I'll see what I can do, but if that doesn't work out I'll just patiently await for it to show up in libvgm I guess.
Thanks for the reply though.

Also I haven't looked at VGMPlay code a lot yet, but would you know where this DC offset fix is applied (for experimental purposes)?

@ValleyBell
Copy link
Contributor

I "enforce" it by manually integrating it into the sound cores.

An example would be the "bipolar output" patch for the SAA1099.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants