Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade redux #1610

Open
smcmurtry opened this issue Dec 14, 2018 · 1 comment
Open

Upgrade redux #1610

smcmurtry opened this issue Dec 14, 2018 · 1 comment
Labels
medium priority technical debt

Comments

@smcmurtry
Copy link
Collaborator

https://github.com/reduxjs/react-redux/releases

It looks like store will no longer be passed as a prop to connected components in the new redux version. It's moving to the page context or something? That will break the way we are mocking redux in the tests.
@smcmurtry smcmurtry mentioned this issue Dec 14, 2018
Merged
@sastels
Copy link
Collaborator

sastels commented Dec 18, 2018

The react-redux docs currently are for v5 😞 We should probably wait at least until they are updated.

@smcmurtry smcmurtry mentioned this issue Mar 19, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
medium priority technical debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@brdunfield @smcmurtry @sastels @SupeDeDupe