Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add firstScanDelay to Retriever.configStream #94

Open
indiketa opened this issue Aug 23, 2019 · 0 comments
Open

Add firstScanDelay to Retriever.configStream #94

indiketa opened this issue Aug 23, 2019 · 0 comments

Comments

@indiketa
Copy link

Use case:
We are using vertx-config to configure a database connection pool, we wanted to replace it with a new one when configuration is changed.

Retriever.configStream seems a perfect fit but it is not:
Setting a scan period of 30 seconds causes an inacceptable delay when verticle starts (30 seconds) because the first configuration is received after the scan period.

In order to solve it:
We are forced to Retriever.getConfig to get the configuration, and then open Retriever.configStream and discard the first read.

OR
Set a lower scanPeriod that introduces unwanted overhead to the system.

Introducing a firstScanPeriod or similar into ConfigRetrieverOptions will be greatly appreciated.

@indiketa indiketa changed the title Add firstScanPeriod to streams Add firstScanPeriod to Retriever.configStream Aug 23, 2019
@indiketa indiketa changed the title Add firstScanPeriod to Retriever.configStream Add firstScanDelay to Retriever.configStream Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant