Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Implement Context Menu #225

Open
pewsheen opened this issue Nov 11, 2024 · 2 comments
Open

Feature: Implement Context Menu #225

pewsheen opened this issue Nov 11, 2024 · 2 comments

Comments

@pewsheen
Copy link
Collaborator

pewsheen commented Nov 11, 2024

Let's use this issue to update everything related to the context menu;

Current Status:

  • Platforms:
  • Servo
    • Servo does not emit ShowContextMenu for the moment. Let's see what we can help.
    • Will use a fixed context menu options until servo emits the ShowContextMenu event
    • The interface of Servo ShowContextMenuEvent may need some refactoring, like bringing the webview ID and what the user has selected (link? plain-text? or nothing) and letting the embedder decide what options to show.
@pewsheen pewsheen added bug Something isn't working needs triage This issue need to be triaged labels Nov 11, 2024
@pewsheen pewsheen removed bug Something isn't working needs triage This issue need to be triaged labels Nov 11, 2024
@wusyong
Copy link
Member

wusyong commented Nov 22, 2024

Since wayland doesn't have any menu support and winit hasn't provide trait to create popup surface for wayland yet.
We decided to go with webview implementation on wayland first. Here's how it looks on my device:

2.mp4

@wusyong
Copy link
Member

wusyong commented Nov 22, 2024

Windows and macOS, on the other hand, have the support. And we can utilize the muda crate from Tauri.

context-menu.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants