fix: utm parameters takes precedence over route params #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
|
feugy
deleted the
damien/log-906-investigate-unexpected-path-on-speed-insights-dashboard
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📓 What's in there?
We've been reported that compute route could be using some search parameter names instead of path parameter names.
This PR fixes it.
🧪 How to test?
It has been tested locally with various version of Next.js, both pages and app router, and a special version of the debug script (soon released) which prints collected metrics to console.
In the following snapshots, the page has a single
[slug]parameter, and autm_contentsearch parameter.❗ Notes to reviewers
Please note that I've updated our example next.js app to latest router, which includes a change how the Page component can access its path params.
The Node.js version is required by Next@15.
Finally,
@jest/globalsis needed because of biome (which we should consider migrating to, as well as vitest).