Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from 13.1.6 to next 13.2.4 fails production build #47340

Closed
1 task done
ryandegruyter opened this issue Mar 21, 2023 · 11 comments
Closed
1 task done

Upgrade from 13.1.6 to next 13.2.4 fails production build #47340

ryandegruyter opened this issue Mar 21, 2023 · 11 comments
Labels
bug Issue was opened via the bug report template. please add a complete reproduction Please add a complete reproduction.

Comments

@ryandegruyter
Copy link

ryandegruyter commented Mar 21, 2023

Verify canary release

  • I verified that the issue exists in the latest Next.js canary release

Provide environment information

"@nrwl/next": "15.8.7"

Operating System:
      Platform: darwin
      Arch: arm64
      Version: Darwin Kernel Version 22.3.0: Mon Jan 30 20:38:37 PST 2023; root:xnu-8792.81.3~2/RELEASE_ARM64_T6000
    Binaries:
      Node: 16.17.1
      npm: 9.2.0
      Yarn: N/A
      pnpm: N/A
    Relevant packages:
      next: 13.2.4
      eslint-config-next: 13.2.4
      react: 18.2.0
      react-dom: 18.2.0

Which area(s) of Next.js are affected? (leave empty if unsure)

No response

Link to the code that reproduces this issue

/

To Reproduce

"@nrwl/next": "15.8.7" + "next": "13.2.4"

Describe the Bug

When running
nx export website

Receiving numerous errors of this type:

Attempted import error: 'ReactComponent' is not exported from '../../public/img/logos/alpha.svg' (imported as 'AlphaSvg').

import code:

import { ReactComponent as AlphaSvg } from '../../public/img/logos/alpha.svg';

And

Error: Minified React error #130; visit https://reactjs.org/docs/error-decoder.html?invariant=130&args[]=undefined&args[]= for the full message or use the non-minified dev environment for full errors and additional helpful warnings.
    at Zc (/Users/.../node_modules/react-dom/cjs/react-dom-server.browser.production.min.js:74:493)

Expected Behavior

Build succeeds without any errors like v13.1.6 or please clarify any breaking changes.

Which browser are you using? (if relevant)

No response

How are you deploying your application? (if relevant)

No response

@ryandegruyter ryandegruyter added the bug Issue was opened via the bug report template. label Mar 21, 2023
@ryandegruyter
Copy link
Author

My original issue was closed in favor of issue 46374. Despite its resolution, my problem persists, so I'm opening this issue.

@balazsorban44
Copy link
Member

balazsorban44 commented Mar 21, 2023

Could you please attach a minimial public reproduction?

/ is not a link to a reproduction. Please make sure to remove any unnecessary code that does not contribute to the observed issue so we can track the potential problem down more easily.

@balazsorban44 balazsorban44 added the please add a complete reproduction Please add a complete reproduction. label Mar 21, 2023
@vercel vercel deleted a comment from github-actions bot Mar 21, 2023
@balazsorban44
Copy link
Member

balazsorban44 commented Mar 21, 2023

Potentially fixed in Nx, see #46374 (comment) Feel free to close the issue if true, otherwise we will need a reproduction.

@Tirke
Copy link

Tirke commented Mar 21, 2023

@balazsorban44 On my side when I bump nx to 15.8.7, our next 13.1.6 app is now failing to build with similar errors found in the previous issue like

../../../libs/front/api/src/logic/axios/auth/clearCookies.ts
Module parse failed: Unexpected token (1:12)
You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
> import type { FrontLegacyRuntimeConfig } from '@front/runtime-config'

@balazsorban44
Copy link
Member

balazsorban44 commented Mar 21, 2023

Please, add a reproduction.

See the message from Tim #46374 (comment)

Also, you might need to bump next as well.

@Tirke
Copy link

Tirke commented Mar 21, 2023

I know we need a repro, takes time that I don't have currently. Same errors when I bump next and nx. No worries on my side can wait. Thanks :)

@balazsorban44
Copy link
Member

This issue has been automatically closed because it received no activity for a month and had no reproduction to investigate. If you think it was closed by accident, please leave a comment. If you are running into a similar issue, please open a new issue with a reproduction. Thank you.

@calvincchong
Copy link

Hi I wanted to know if this was resolved?

@ryandegruyter
Copy link
Author

Hi @calvincchong, I did an upgrade to the latest nextjs version without upgrading nrwl/next. That worked, then I upgraded nrwl/next and I got the above mentioned errors, I moved the issue to nrwl/nx#16361

@ryandegruyter
Copy link
Author

We resolved the issue, see my comment here: nrwl/nx#16361 (comment)

@github-actions
Copy link
Contributor

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue was opened via the bug report template. please add a complete reproduction Please add a complete reproduction.
Projects
None yet
Development

No branches or pull requests

4 participants