This repository has been archived by the owner on Dec 20, 2024. It is now read-only.
Is there a way to have Vercel for Github wait for Github Action to complete before deploying? #390
Locked
aegatlin
started this conversation in
Show & Tell
Replies: 1 comment 1 reply
-
see my comment on concurrent CI here: #285 (reply in thread) On the linked thread a workaround is proposed … (Github actions issueing deploy hook and only then build not from code push/update) |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
I want to run my GH action tests on my main branch, and if they fail, I don't want Vercel to deploy to prod. At the moment it will deploy to prod before the test suite even runs.
Additional Context (skippable)
The only workflow that seems "simple" for Vercel is a branch-based paradigm, where my GH-action tests run against the PR and I get the PR previews. That workflow makes the changes feel safe, so that's great! But, I would also like to have a trunk-based paradigm be "simple" as well. So, I push small changes directly to main (i.e., the prod branch) and have them run through a GH-action tests before auto-deploying via Vercel-for-Github. If the tests fail, Vercel doesn't deploy. I'm imagining some setting somewhere that is like
waitForActions: true
, so I don't have to use a 3rd-party vercel deploy action that uses the deploy hooks, etc., but is instead a first-party solution. So, my questions are: (1) is there a "simple" trunk-based solution already? (2) If not, are there plans for one? (3) Am I missing some simpler solution, somehow?I love Vercel and what yall are doing. Keep it up! :D <3
Beta Was this translation helpful? Give feedback.
All reactions