Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the successor market docs #853

Closed
2 of 3 tasks
daniel1302 opened this issue Dec 14, 2023 · 1 comment · Fixed by #854
Closed
2 of 3 tasks

Improve the successor market docs #853

daniel1302 opened this issue Dec 14, 2023 · 1 comment · Fixed by #854
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@daniel1302
Copy link
Contributor

daniel1302 commented Dec 14, 2023

Feature overview

One of the market makers returned the issue with successor market documentation. I think it would be good to write it ASAP:

> Hello, I am a bit confused by the successor market docs. I don't see the necessary fields in the examples
> Am I blind or are they missing?
> Also is it the same process for Perps? The decimals on the LINK market are a bit silly so I'm going to propose we close it and re-open it using the successor feature
> https://docs.vega.xyz/mainnet/tutorials/proposals/new-successor-market-proposal
> Also when we make a proposal for a successor market while the parent is active does this mean that the protocol duplicates our LP commitments or will thye automatically be withdrawn from the parent market at enactment time of the successor market?

Tasks

A checklist of the tasks that are needed to document the requested topic fully.

  • Test current documentation
  • Update docs
  • Make sure we create successor market on one of our internal docs
@daniel1302 daniel1302 self-assigned this Dec 14, 2023
@vega-issues vega-issues added the documentation Improvements or additions to documentation label Dec 14, 2023
@daniel1302 daniel1302 moved this to In Progress in Core Kanban Dec 14, 2023
@edd edd self-assigned this Dec 14, 2023
@candida-d candida-d moved this from NEW to INPROG in Frontend Engineering Dec 14, 2023
@github-project-automation github-project-automation bot moved this from INPROG to DONE in Frontend Engineering Dec 14, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Merged in Core Kanban Dec 14, 2023
@edd
Copy link
Contributor

edd commented Dec 14, 2023

@daniel1302 thanks for reporting this, it's now fixed. The fields were there in the past, but I removed them in another change by mistake. My fault, sorry for the confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Archived in project
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants