Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Around actions don't work with batch actions #237

Open
Linuus opened this issue Sep 13, 2017 · 0 comments
Open

Around actions don't work with batch actions #237

Linuus opened this issue Sep 13, 2017 · 0 comments
Labels

Comments

@Linuus
Copy link
Contributor

Linuus commented Sep 13, 2017

If you have an around_action in your controllers, they won't work with batch actions since they redirect which halts the filter chain.

Example:

around_action :update_index, only: [:create, :update, :destroy]

  def update_index
    Chewy.atomic do
      yield
    end
  end  

This will not be run when running a batch action.

@Linuus Linuus added the bug label Sep 13, 2017
@jensljungblad jensljungblad changed the title around actions doesn't work with batch actions Around actions doesn't work with batch actions Nov 20, 2017
@jensljungblad jensljungblad changed the title Around actions doesn't work with batch actions Around actions don't work with batch actions Nov 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant