Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the roles of resource service methods #219

Open
jensljungblad opened this issue Feb 21, 2017 · 0 comments
Open

Clarify the roles of resource service methods #219

jensljungblad opened this issue Feb 21, 2017 · 0 comments

Comments

@jensljungblad
Copy link
Contributor

jensljungblad commented Feb 21, 2017

In particular, clarify the roles of resources_relation and resources, perhaps with a rename. They were previously called begin_of_association_chain and end_of_association_chain which were a bit of a mouthful but perhaps more clear. Those names originally came from https://github.com/activeadmin/inherited_resources.

One issue is that the examples we have in the readme are not very good. Both could be implemented using the other function instead. So we should elaborate a bit on why both are needed. Currently, I can't remember 😳

@jensljungblad jensljungblad changed the title Clarify the roles of resource service resources_relation and resources Clarify the roles of resource service methods Feb 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant