Resolve RecipeVariants type to improve IDE hint #1161
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, when testing out vanilla-extract, I found that the type hints are currently very verbose with the generic
RecipeVariants
type and not readable.For example when having a button that has the variants
look
,size
,pill
andsquare
, it currently looks like this in my IDE (VSCode):By using a generic type like this:
you can kind of "resolve" the type and only display the actually underlying type:
which has much better readability! :)
This is not changing the type itself, it is more like reassigning the attributes to a new type.
Loving the project so far, great work!♥️