Rollup Version

[smholsen]

Hey!
(cc: @askoufis , @mrm007 )

In our root project where we use vanilla-extract, we have a dev dependency on [email protected], which results in a peer dependency issue (warn) when we include vanilla-extract.

> @vanilla-extract/[email protected]" has incorrect peer dependency "rollup@^2.0.0 || ^3.0.0"

I might be wrong, but it seems this stems from the following deps in vanilla-extract:
https://github.com/vanilla-extract-css/vanilla-extract/blob/master/package.json#L48-L50

I assume it would be desirable to upgrade these to more recent versions;
https://www.npmjs.com/package/rollup-plugin-dts: from 4.x.x to 6.x.x
https://www.npmjs.com/package/rollup-plugin-node-externals: from 5.x.x to 6.x.x
https://www.npmjs.com/package/rollup: from 2.x.x to 4.x.x

Is this something that's already planned for a later major version upgrade of vanilla-extract, or is this something we could already submit a PR for?

[mrm007]

Thanks for reporting this. The linked package.json is for the monorepo, and is unrelated to the dependencies for the Rollup plugin. We use Rollup and those plugins for packaging type definitions: https://github.com/vanilla-extract-css/vanilla-extract/blob/master/scripts/build-dts.ts#L7-L9

The peer dependency for the plugin is declared here: https://github.com/vanilla-extract-css/vanilla-extract/blob/master/packages/rollup-plugin/package.json#L29. If you'd like to contribute a PR, I'll help review it. Just need to add ^4.0.0 to that range, which would be a minor version bump.

[smholsen]

Thanks @mrm007 !
I've spun up this: #1290

[mrm007]

Released in @vanilla-extract/[email protected]