Modifying code to use custom Parameter groups for RDS #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JamesSWiggins @qing-at-work Do you all agree with this suggested change? |
|
Changes look good, the only suggestion that I have is to convert parameters from parameter groups as cloudformation template parameters, so that users can see and update these parameters when deploying cloudformation templates, otherwise, they would need to update the specific cloudformation template when they need to change these parameters. |
|
@JustinRajDeveloper Would you be able to also make the suggested changes that @qing-at-work mentioned above? |
|
Hi Rob,
Yea i can do that changes.
Thanks,
Justin.
…On Tue, Sep 26, 2023 at 10:00 PM Rob Taylor ***@***.***> wrote:
@JustinRajDeveloper <https://github.com/JustinRajDeveloper> Would you be
able to also make the suggested changes that @qing-at-work
<https://github.com/qing-at-work> mentioned above?
—
Reply to this email directly, view it on GitHub
<#33 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJHBMULQH6IPRJ4WWXBRYKTX4L7LZANCNFSM6AAAAAA5EH6VUM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***
com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous commit #32 fixed Mysql incompatible issues but its using default parameter group we are unable to modify default parameter group if we want to add additional param. This commit will fix that issue.