FTBFS: Missing header & functions

[OPNA2608]

This include is broken:

libfmvoice/fmbankdump.c

Line 4 in e3b08e2

#include "fm_voice.h"

cc -Wall -O2 -DHAVE_STDIO -DENABLE_LOADERS -MMD -c fmbankdump.c -o fmbankdump.o
[...]
fmbankdump.c:4:10: fatal error: fm_voice.h: No such file or directory
  4 | #include "fm_voice.h"
    |          ^~~~~~~~~~~~

The header got moved to fm_voice_bank.h, and the fm_voice_bank_load function this code wants to use was dropped.

/nix/store/2p1sq1nr09xr3xb1a9lrjgdanvk1aakb-binutils-2.42/bin/ld: fmbankdump.o: in function `main':
fmbankdump.c:(.text.startup+0x67): undefined reference to `fm_voice_bank_load'

---

fb01dump complains about missing function:

/nix/store/2p1sq1nr09xr3xb1a9lrjgdanvk1aakb-binutils-2.42/bin/ld: fb01dump.o: in function `main':
fb01dump.c:(.text.startup+0x120): undefined reference to `fb01_bulk_voice_bank_dump'

fb01dump uses fb01_bulk_voice_bank_dump:

libfmvoice/fb01dump.c

Line 42 in e3b08e2

fb01_bulk_voice_bank_dump(&bank);

The header says this should exist, unless we're building for emscripten:

libfmvoice/syx_fb01.h

Lines 148 to 151 in e3b08e2

	#ifndef __EMSCRIPTEN__
	void fb01_bulk_voice_dump(struct fb01_bulk_voice *voice, int voicenum);
	void fb01_bulk_voice_bank_dump(struct fb01_bulk_voice_bank *bank);
	#endif /* __EMSCRIPTEN */

But it's only implented when we don't HAVE_STDIO:

libfmvoice/syx_fb01.c

Line 195 in e3b08e2

#ifndef HAVE_STDIO

[…]

libfmvoice/syx_fb01.c

Lines 249 to 269 in e3b08e2

	void fb01_bulk_voice_bank_dump(struct fb01_bulk_voice_bank *bank) {
	printf(
	"bank %d, channel %d, name=%c%c%c%c%c%c%c%c voices=%d\n",
	bank->bank,
	bank->channel,
	safechar(bank->name[0]),
	safechar(bank->name[1]),
	safechar(bank->name[2]),
	safechar(bank->name[3]),
	safechar(bank->name[4]),
	safechar(bank->name[5]),
	safechar(bank->name[6]),
	safechar(bank->name[7]),
	bank->num_voices
	);
	for(int i = 0; i < bank->num_voices; i++) {
	struct fb01_bulk_voice *voice = bank->voices + i;
	fb01_bulk_voice_dump(voice, i);
	}
	}
	#endif

And the Makefile says that we do HAVE_STDIO:

libfmvoice/Makefile

Line 3 in e3b08e2

CFLAGS?=-Wall -O2 -DHAVE_STDIO -DENABLE_LOADERS

[vampirefrog]

sorry buddy this code is in flux and I haven't had hobby time lately. I'll fix it eventually

[vampirefrog]

you can probably use an older version that still compiles and runs well enough

[vampirefrog]

The plan is to use streamlib for I/O but that one is not finished yet.

[vampirefrog]

okay try now @OPNA2608