Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Antivirus warnings on Windows #305

Open
oaksprout opened this issue Aug 30, 2024 · 3 comments
Open

Antivirus warnings on Windows #305

oaksprout opened this issue Aug 30, 2024 · 3 comments
Labels
bug Something isn't working severity: very high

Comments

@oaksprout
Copy link
Collaborator

oaksprout commented Aug 30, 2024

McAfee: https://discord.com/channels/899649805582737479/1244588374736502847/1278970717018521621
Windows Defender: https://valory-workspace.slack.com/archives/C07CF1X7LCW/p1725015072732809

Severity: at least 4 reports, probably many more suffering from it. Confirmed that it totally blocks 2 users from running the agent.

@oaksprout oaksprout added bug Something isn't working severity: high labels Aug 30, 2024
@truemiller
Copy link
Collaborator

truemiller commented Aug 30, 2024

Yeah, I'm getting spammed with Avast popups too on the Windows release, though they resolve to being safe after some time period.

@oaksprout
We should look into:

  • Windows code signing
  • Automating AV submissions to major vendors -- Norton, Avast, McAfee, NOD32, VirusTotal -- once
    release completes

update:

  • we may need to do this for each binary, cli, aea, tendermint, .etc
    image

@oaksprout oaksprout changed the title McAfee warning Antivirus warnings on Windows Aug 30, 2024
@oaksprout
Copy link
Collaborator Author

Yikes, OK

@truemiller
Copy link
Collaborator

an update on the code signing:
the bundled binaries should all be code-signed when using electron-builder for the release as we already do.

it's unlikely that we'll need to code-sign separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working severity: very high
Projects
None yet
Development

No branches or pull requests

2 participants