Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spot prices received individually down the stream #44

Merged
merged 2 commits into from
Dec 28, 2023
Merged

spot prices received individually down the stream #44

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0597b12
return prices in a stream rather than a stream of arrays
megsdevs Dec 19, 2023
01f010f
no need to wrap in response struct
megsdevs Dec 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions proto/valorem/trade/v1/spot.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ service Spot {
// stream of SpotPriceResponse: Continuously streams data about the spot prices
// of the requested tokens on their respective chains
// as updates are available.
rpc GetSpotPrice (SpotPriceRequest) returns (stream SpotPriceResponse);
rpc GetSpotPrice (SpotPriceRequest) returns (stream SpotPriceInfo);
}

// SpotPriceRequest encapsulates the details of the tokens for which
Expand All @@ -31,14 +31,6 @@ message SpotPriceRequest {
repeated SpotPriceInfo spot_price_info = 1;
}

// SpotPriceResponse provides the fetched spot prices for the tokens specified in the request.
message SpotPriceResponse {

// spot_price_info holds the data about the fetched spot prices for each of the
// tokens specified in the request.
repeated SpotPriceInfo spot_price_info = 1;
}

// SpotPriceInfo represents the details and the spot price (if available) for a single token
// on a particular blockchain.
message SpotPriceInfo {
Expand Down
Loading