Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directions to add new function #161

Open
delmonij opened this issue Feb 27, 2019 · 2 comments
Open

Directions to add new function #161

delmonij opened this issue Feb 27, 2019 · 2 comments
Labels

Comments

@delmonij
Copy link

I'm trying to add support for a small excel plugin I use. It's invocation is like _XLL.FNX(). It seems like It would obey the same properties as currently implemented properties. Can you point me in the right direction about where I should go about trying to add this capability?

@danielsjf
Copy link
Collaborator

All the excel functions are in this file:
https://github.com/anthill/koala/blob/master/koala/excellib.py

Adding a new function is as simple as creating a new Python function there. It should obey the following standards:

  • Have the same name as the excel function (albeit lowercase).
  • Have the same number of arguments as the excel function. The names of the arguments are not important, but using the same as Excel is recommended.

In addition to this, also add the name to the list at the top of that page.

Here is an example pull request:
https://github.com/anthill/koala/pull/178/files

@danielsjf danielsjf added the Doc label Sep 4, 2019
@danielsjf
Copy link
Collaborator

A full guidance will be included in the docs once #233 gets merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants