Fix the wrong woff when execute WAIT / WAITAOF in script #776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zuiderkwast this is the reason why #766 failed. The other test enable the appendonly, and the c->woff is always 0, so 0 >= 0 is always true |
When executing the script, the client passed in is a fake client, and its woff is always 0. Signed-off-by: Binbin <[email protected]>
enjoy-binbin
force-pushed
the
fix_client_woff
branch
from
0f9e388 to
5f6280c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #776 +/- ##
============================================
+ Coverage 70.04% 70.24% +0.20%
============================================
Files 112 112
Lines 60602 60608 +6
============================================
+ Hits 42447 42574 +127
+ Misses 18155 18034 -121
|
Signed-off-by: Binbin <[email protected]>
zuiderkwast
reviewed
Jul 12, 2024
zuiderkwast
reviewed
Jul 12, 2024
Signed-off-by: Binbin <[email protected]>
Signed-off-by: Binbin <[email protected]>
Signed-off-by: Binbin <[email protected]>
zuiderkwast
approved these changes
Jul 13, 2024
There was a problem hiding this comment.
I thought with this fix, we don't need to change 0 to * (#775), but that's OK too.
we still need to change 0 to *, if the appendonly is yes, the test will still fail. that is because when we are executing the script, neither fsynced_off nor woff are updated, so we will still get the old (prev) values in waitaof. |
enjoy-binbin
added
the
release-notes
hwware
pushed a commit
to hwware/valkey
that referenced
this pull request
Jul 25, 2024
When executing the script, the client passed in is a fake client, and its woff is always 0. This results in woff always being 0 when executing wait/waitaof in the script, and the command returns a wrong number. --------- Signed-off-by: Binbin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When executing the script, the client passed in is a fake
client, and its woff is always 0.
This results in woff always being 0 when executing wait/waitaof
in the script, and the command returns a wrong number.