Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix query buffer resized test flakiness #646

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

uriyage
Copy link
Contributor

@uriyage uriyage commented Jun 13, 2024

Fix query buffer resized correctly test by removing a flaky "after"
Failure example: https://github.com/valkey-io/valkey/actions/runs/9457340771/job/26050970622

*** [err]: query buffer resized correctly in tests/unit/querybuf.tcl
Expected 11 >= 16384 && 11 <= 32770 (context: type eval line 24 cmd {assert {$orig_test_client_qbuf >= 16384 && $orig_test_client_qbuf <= $MAX_QUERY_BUFFER_SIZE}} proc ::test)
*** [err]: query buffer resized correctly when not idle in tests/unit/querybuf.tcl
Expected 11 > 32768 (context: type eval line 14 cmd {assert {$orig_test_client_qbuf > 32768}} proc ::test)
*** [err]: query buffer resized correctly with fat argv in tests/unit/querybuf.tcl
query buffer should not be resized when client idle time smaller than 2s

Copy link

codecov bot commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.22%. Comparing base (b546dd2) to head (200cb3a).

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable     #646      +/-   ##
============================================
- Coverage     70.22%   70.22%   -0.01%     
============================================
  Files           110      110              
  Lines         60039    60039              
============================================
- Hits          42163    42160       -3     
- Misses        17876    17879       +3     

see 9 files with indirect coverage changes

Copy link
Member

@enjoy-binbin enjoy-binbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please fix the DCO

@uriyage uriyage force-pushed the fix_qb_resize_test_2 branch from c5c63a3 to 200cb3a Compare June 13, 2024 08:46
@enjoy-binbin enjoy-binbin merged commit d211078 into valkey-io:unstable Jun 13, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants