Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Module Update Args test when other modules are loaded #1403

Conversation

zuiderkwast
Copy link
Contributor

Fixes #1400

@zuiderkwast zuiderkwast added the run-extra-tests Run extra tests on this PR (Runs all tests from daily except valgrind and RESP) label Dec 6, 2024
@zuiderkwast zuiderkwast requested a review from hwware December 6, 2024 22:56
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.70%. Comparing base (6df376d) to head (aa69486).
Report is 13 commits behind head on unstable.

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #1403      +/-   ##
============================================
- Coverage     70.82%   70.70%   -0.13%     
============================================
  Files           118      118              
  Lines         63561    63561              
============================================
- Hits          45020    44938      -82     
- Misses        18541    18623      +82     

see 12 files with indirect coverage changes

@zuiderkwast zuiderkwast merged commit a2fe6af into valkey-io:unstable Dec 7, 2024
54 of 56 checks passed
@zuiderkwast zuiderkwast deleted the fix-module-update-args-fail-with-other-modules branch December 7, 2024 09:25
@hwware
Copy link
Member

hwware commented Dec 9, 2024

@zuiderkwast Thanks for fixing it.

@zuiderkwast zuiderkwast added the test-failure An issue indicating a test failure label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-extra-tests Run extra tests on this PR (Runs all tests from daily except valgrind and RESP) test-failure An issue indicating a test failure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[test-failure] Module Update Args test fails on TLS-module CI jobs
3 participants