Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Opt-in for inclusive language (primary/replia in ROLE reply, CLUSTER SHARDS, etc.) #751

Open
zuiderkwast opened this issue Jul 5, 2024 · 4 comments

Comments

@zuiderkwast
Copy link
Contributor

The problem/use-case that the feature addresses

As mentioned in #36, changing "master" and "slave" the replies of commands like ROLE and CLUSTER SHARDS are breaking changes. From feedback, we've learned that backward compatibility is more important than inclusive language.

Description of the feature

Opt-in for inclusive language. An idea is to use CLIENT CAPA introduced in #325. Idea:

  • CLIENT CAPA inclusive-language
  • CLIENT CAPA woke 🤣
  • CLIENT CAPA primary-replica

When a client has declared this capability, the server can send "primary" and "replica" in replies to ROLE and other commands.

Alternatives you've considered

  • Breaking change (not appreciated by users)
  • No change at all (some people will complain forever that we still use non-inclusive language)

Additional information

Any non-breaking change, such as adding aliases, can be done in the scope of #36.

@PingXie
Copy link
Member

PingXie commented Jul 5, 2024

CLIENT CAPA Redis? :)

@zuiderkwast
Copy link
Contributor Author

It's about compatibility with Valkey 7.2.x too though.

@PingXie
Copy link
Member

PingXie commented Jul 6, 2024

That still works. It is just a different default value. We could argue that Valkey 7.2 defaults to "Redis" compatible but then we change the default compat value in Valkey X.0.

@PingXie
Copy link
Member

PingXie commented Jul 6, 2024

Similarly we could introduce "CLIENT CAPA Valkey" too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants