Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Flaky cluster tests 11-manual-takeover.tcl in 7.2 #609

Closed
PingXie opened this issue Jun 7, 2024 · 2 comments · Fixed by #651
Closed

[BUG] Flaky cluster tests 11-manual-takeover.tcl in 7.2 #609

PingXie opened this issue Jun 7, 2024 · 2 comments · Fixed by #651

Comments

@PingXie
Copy link
Member

PingXie commented Jun 7, 2024

This happened in 7.2 branch. 11-manual-takeover.tcl failed with Error: The operation was canceled.

https://github.com/valkey-io/valkey/actions/runs/9409039001/job/25920054481?pr=608#step:9:434
@hpatro
Copy link
Contributor

hpatro commented Jun 12, 2024

I think it has do to with the infinite loop inside clusterNodeGetPrimary.

Discussed more here: #573 (comment)

This was referenced Jun 13, 2024
Open
Merged
@PingXie
Copy link
Member Author

PingXie commented Jun 14, 2024

Wanted to add at least one of the situations that could lead to a circular replicaof chain (explained at https://github.com/valkey-io/valkey/blob/unstable/src/cluster_legacy.c#L3130-L3163) should be fixed by redis/redis#13055 already. So this infinite loop could be a different issue.

@PingXie PingXie mentioned this issue Jun 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix potential infinite loop in clusterNodeGetPrimary PingXie/valkey
2 participants
@PingXie @hpatro