Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dead loop when transfer large data (size>20474 Byte) by rdma #1386

Open
wants to merge 1 commit into
base: unstable
Choose a base branch
from

Conversation

fengquyoumo
Copy link

Fixes #1385

Determine the status of the Client when attempting to read data. If state=CLIENT_COMPLETED_IO, no read attempt is made and I/O operations on the Client are rescheduled by the main thread.

And 20474 Byte = PROTO_IOBUF_LEN(16KB) + SDS_HDR_VAR(16, s)(4090 Byte)

(Also. I am a newcomer, please bear with me for my English expression and description ability)

@zuiderkwast
Copy link
Contributor

@pizhenwei RDMA expert, please take a look.

@fengquyoumo Thanks for your contribution. You need to commit with git commit -s which adds the Signed-off-by header in the commit message. See CONTRIBUTING.md about why we need this. How to fix it, see the Details link at the "DCO" CI job.

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.85%. Comparing base (3df609e) to head (e99df1e).
Report is 4 commits behind head on unstable.

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #1386      +/-   ##
============================================
+ Coverage     70.78%   70.85%   +0.06%     
============================================
  Files           118      118              
  Lines         63497    63549      +52     
============================================
+ Hits          44945    45026      +81     
+ Misses        18552    18523      -29     
Files with missing lines Coverage Δ
src/rdma.c 100.00% <ø> (ø)

... and 18 files with indirect coverage changes

@pizhenwei
Copy link
Contributor

Hi @fengquyoumo
I've got a cold, and will be back soon. please be a little more patient.

@fengquyoumo
Copy link
Author

@zuiderkwast :) Thanks for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants