Skip to content

Commit

Permalink
Update module API comment and remove test case name space
Browse files Browse the repository at this point in the history
  • Loading branch information
hwware committed Nov 29, 2024
1 parent fc31906 commit 9de9f2a
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
4 changes: 1 addition & 3 deletions src/module.c
Original file line number Diff line number Diff line change
Expand Up @@ -2259,9 +2259,7 @@ int moduleIsModuleCommand(void *module_handle, struct serverCommand *cmd) {
* represents the values of the updated arguments.
* Once 'CONFIG REWRITE' command is called, the updated argument values can be saved into conf file.
*
* Returns:
* - VALKEYMODULE_ERR on failure.
*/
* The function always returns VALKEYMODULE_OK. */
int VM_UpdateRuntimeArgs(ValkeyModuleCtx *ctx, ValkeyModuleString **argv, int argc) {
struct moduleLoadQueueEntry *loadmod = ctx->module->loadmod;
for (int i = 0; i < loadmod->argc; i++) {
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/moduleapi/moduleconfigs.tcl
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ start_server {tags {"modules"}} {
assert_equal [r config get moduleconfigs.memory_numeric] "moduleconfigs.memory_numeric 1024"
}
}
test {Module Update Args } {
test {Module Update Args} {
r module load $testmoduleparameter 10 20 30

set t [r module list]
Expand Down

0 comments on commit 9de9f2a

Please sign in to comment.