Fix race condition dualChannelSync abort after local replication buff…

…er stream Signed-off-by: Ubuntu <[email protected]>
valkey-io · Jul 23, 2024 · 534596c · 534596c
1 parent 7cd8c5e
commit 534596c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/src/replication.c b/src/replication.c
@@ -2862,6 +2862,8 @@ void dualChannelSyncSuccess(void) {
     if (streamReplDataBufToDb(server.primary) == C_ERR) {
         /* Sync session aborted during repl data streaming. */
         serverLog(LL_WARNING, "Failed to stream local replication buffer into memory");
+        replicationAbortDualChannelSyncTransfer();
+        replicationUnsetPrimary();
         return;
     }
     freePendingReplDataBuf();

diff --git a/tests/integration/replication-buffer.tcl b/tests/integration/replication-buffer.tcl
@@ -27,6 +27,9 @@ start_server {} {
     # Make sure replica3 is synchronized with master
     $replica3 replicaof $master_host $master_port
     wait_for_sync $replica3
+    if {$dualchannel == "yes"} {
+        wait_for_ofs_sync $master $replica3
+    }
 
     # Generating RDB will take some 100 seconds
     $master config set rdb-key-save-delay 1000000