Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Google Analytics support #111

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Add Google Analytics support #111

merged 1 commit into from
Aug 9, 2024

Conversation

mercuryseries
Copy link
Collaborator

Checklist:

  • Was this PR discussed in a issue? It is recommended to first discuss a new feature into a GitHub issue before opening a PR.
  • Add tests to cover the fixed bug(s) or the new introduced feature(s) (if appropriate).
  • Update the API documentation is a new function is added or an existing one is deleted.

@mercuryseries mercuryseries requested a review from prtos as a code owner August 9, 2024 20:28
@mercuryseries mercuryseries requested a review from FNTwin August 9, 2024 20:28
@@ -1,5 +1,5 @@
:root {
--openqdc-primary: ##201342;
--openqdc-primary: #201342;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small typo

mkdocs.yml Outdated
Comment on lines 139 to 156
analytics:
provider: google
property: G-3ESBDCXFTZ
# Widget at the bottom of every page to collect information about the user experience
# The data is collected in Google Analytics
feedback:
title: Was this page helpful?
ratings:
- icon: material/emoticon-happy-outline
name: This page was helpful
data: 1
note: >-
Thanks for your feedback!
- icon: material/emoticon-sad-outline
name: This page could be improved
data: 0
note: >-
Thanks for your feedback!
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FNTwin
Copy link
Collaborator

FNTwin commented Aug 9, 2024

Thank you Honore, I'll run the pre-commit on my own, repush and merge it EDIT: Oh well, didn't need me

@mercuryseries mercuryseries force-pushed the feat-add-google-analytics branch from c068dd5 to b7b7ec7 Compare August 9, 2024 20:30
Copy link
Collaborator

@FNTwin FNTwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FNTwin FNTwin merged commit e052bf6 into main Aug 9, 2024
13 checks passed
@FNTwin FNTwin deleted the feat-add-google-analytics branch August 13, 2024 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants