Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player Images #184

Open
Ron111104 opened this issue Sep 19, 2024 · 4 comments
Open

Player Images #184

Ron111104 opened this issue Sep 19, 2024 · 4 comments

Comments

@Ron111104
Copy link

probably try to add images for each player which are already hosted i.e the image links .
Not sure if you have already done it since in players_raw.csv had seen an image column but it had some numbers eg:23105.jpeg but couldnt locate it

@vaastav
Copy link
Owner

vaastav commented Sep 20, 2024

Yea, this isn't something I added because I never found any use for the images. The image column has the suffix for the common link where the image files are hosted.

Is this something that people actually want as part of the dataset? I am not sure what the utility of these images would be.

@Ron111104
Copy link
Author

ah okay
for my usecase it will be useful especially for the frontend part
One of my models classifies their performance over a season and gives them an appropriate rating
so if possible can u share the common link

@vaastav
Copy link
Owner

vaastav commented Sep 20, 2024

You can get the pictures here: https://resources.premierleague.com/premierleague/photos/players/250x250/

For example, consider Bukayo Saka. His image is at "223340.jpg", then his url would be "https://resources.premierleague.com/premierleague/photos/players/250x250/p223340.png"

Basically, you need to add a p before the start of the number and replace .jpg with .png

@Ron111104
Copy link
Author

okay got it.thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants