Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding security to the tutorial starter breaks unit tests making the build step impassable #4080

Open
bkuntzelman opened this issue Jan 21, 2025 · 0 comments
Labels

Comments

@bkuntzelman
Copy link

bkuntzelman commented Jan 21, 2025

The steps in the Flow tutorial do a good job of taking one thru the typical development of an app (including the typical adding of security late in the game.) However, the tutorial does not go through the remediations of the provided tests in the starter that will fail once Spring Boot Security has been added to/setup in the project.

Thus, when getting to the "Build for Production" step, the maven command fails due to tests failing.

It would be beneficial to go through the step(s) necessary to setup the project/tests/etc. for the post-security environment ... or omit the tests entirely from the starter as they're not discussed in the tutorial? Or include the -DskipTests option to the maven build command to let the build succeed regardless of the state of the tests. Granted, as a Spring Boot developer, I could probably go through the tests and fix them, but this is a tutorial and IMO, it shouldn't require outside knowledge.

I did note, however, that the source in the github tutorial project appears to have a suggested end-state for Flow and Hilla tutorials in the project, so thumbs-up there.


If you think this issue is important, add a 👍 reaction to help the community and maintainers prioritize this issue.

@yuriy-fix yuriy-fix added the flow label Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants