Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkpoint Question #19

Open
vthost opened this issue Mar 14, 2022 · 5 comments
Open

Checkpoint Question #19

vthost opened this issue Mar 14, 2022 · 5 comments

Comments

@vthost
Copy link

vthost commented Mar 14, 2022

Hi,
Thank you providing the code and details about the data leakage. I just want to make sure I understand correctly: We can still use the old checkpoints but need to update the code (canonicalize_products.py) as described?
Thank you so much already!

@chaoyan1037
Copy link
Contributor

Hi, We can do that. But performance will not be good.

@vthost
Copy link
Author

vthost commented Mar 14, 2022

Do you maybe have an updated checkpoint which you could provide?

@vthost
Copy link
Author

vthost commented Mar 21, 2022

Hi, did you check if you could share your models?

@chaoyan1037
Copy link
Contributor

Hi there, thanks for your interest! We are still working on the updated code and models. Not sure when will be ready to release the code and models.

@vthost
Copy link
Author

vthost commented Mar 22, 2022

Ok, thank you for letting me know!
I misunderstood the state of the project and thought you did run the updated model since in Issue #17 it says "Our proposed method is still ... effective." Could you please share it once you have it? It's a nice approach!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants