-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ustream.lxc packer integration #11
Comments
Hi, great to hear you are having success with it! We've been using it with a patched version of packer to publish vagrant-lxc boxes: https://github.com/oker1/packer/commits/vagrant-lxc I didn't send a PR from it because the vagrant-lxc box format was not final at that time. I haven't been following the project since, don't know if it has been finalized or not. |
Ah thats great thanks, I'll give it a try. I would consider merging packer 0.7.5 with this vagrant-lxc branch and then just file a PR at mitchellh/packer anyway and get the conversation rolling with that PR? Would be great to get it finally included. Thanks again! |
That would be great! |
You wanna do the PR, or shall I? |
Go ahead and create it please :) |
Any chance of getting the user variable expansion in first? Or do you want me to do some more work on it? |
I've created a fork : https://github.com/grenzr/packer ready for PR (just testing it, and assessing what tests need to be written) |
As per vagrant-lxc box format, I can say that is "final" these days. "Final" as in we haven't had a need to change it in a looooong time, so it is stable at least ;-) |
@fgrehm thats good news, thanks :) |
@grenzr yeah it's a PR here in this repo. I wasn't aware of the other one. |
Hi all - sorry have been away for a while. I have successfully tested it and it works fine. I was just wondering whether any tests needed to be written for it before submission to main packer repo. I will hopefully get a chance to look at this again this week if nobody else has already? |
@grenzr in answer to your question to @perj above, the User variable stuff is in packer-builder-lxc. It's issue #2 and has a pr #7. I agree with @perj that this is probably a necessary change before it gets merged into packer proper (since the expectation for all other packer resources is to handle the User variables.) |
Any word on when the user variables PR might be merged? EDIT: User variables appear to work fine, assuming they do unless someone comments otherwise. Thanks. |
I've merged it now. I couldn't test it extensively but seems like it didn't break anything. |
I haven't run into any problems yet, but I'm going to be using this builder frequently so I'll let you know if I run into any issues regarding the variables. |
Guess I should leave a comment to point out that I'm still around. 😄 |
I've released a new preview version, which creates a working vagrant box for the latest vagrant-lxc release. The example config uses the compress postprocessor to produce the vagrant box. This can work while we figure out how to create a proper vagrant postprocessor plugin (see hashicorp/packer#2537) |
Great work on this builder :) I am successfully building LXC boxes using it, but the major missing part is the ustream.lxc publisher.
I just wanted to find out whether there has been any dev effort on this yet, or can I help collaborate on it as I'd really like to see this feature implemented.
The text was updated successfully, but these errors were encountered: