Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve handling of qualified names when renaming #531
base: main
Are you sure you want to change the base?
Improve handling of qualified names when renaming #531
Changes from all commits
78368fc
a5e9641
6a27810
951d17a
3a78abb
c57048f
7b62cb2
d571b20
9f8d64b
2cbe317
081c880
c2f7645
be73a8d
d5ea288
2eb84b2
9dc8e7d
292acd6
d39ed23
7d23b17
3f80f36
d7865dc
b918896
e4e0956
dd91729
a62056b
841ef40
d931b5d
85b32f3
06d9d24
b30ecff
1c8b52f
4ffc1e7
af85b8a
fc17d67
496f17a
15482f2
d6b64f3
1374f6a
c4f8d60
2257dac
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: if we move this
orElseThrow
into thefindContainingWorkspaceFolder
we don't have to repeat it at the call site. (since it happens twice)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit:
reg
can be inlined.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ideally we keep the work inside the
eval
lock as small as possible. especially since thequalifiedNameChangesFromRenames
can end up callin maven (where there is some different locking happening in the latest version of rascal) we would hate to see a deadlock there.So I would prefer if we can move this code to a completable future "before" this one, and only after that compose that to the
runEvaluator
closure.