Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update pathname validation to use basename for directory checks #2193 #3550

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: update pathname validation to use basename for directory checks #2193 #3550

wants to merge 2 commits into from

Conversation

Pragadesh-45
Copy link
Contributor

@Pragadesh-45 Pragadesh-45 commented Nov 26, 2024 •
edited
Loading

fixes: #2193

Description

This PR implements a fix for #2193. In this PR, I added the isValidPath call for only the basename, as expected by is-valid-path.

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Demo:

demo_issue_2193.mp4

@Pragadesh-45 Pragadesh-45 changed the title fix: implement custom pathname validation #2193 fix: update pathname validation to use basename for directory checks #2193 Nov 27, 2024
@Pragadesh-45 Pragadesh-45 marked this pull request as ready for review November 27, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lohxt1 lohxt1 Awaiting requested review from lohxt1

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

exclamation
1 participant
@Pragadesh-45