Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Berichte: Bei Auswahl von mehreren Personen werden die "Soll Stunden" nicht korrekt angezeigt, wenn eine Person abwesend war #905

Closed
derTobsch opened this issue Oct 25, 2024 · 0 comments · Fixed by #922
Closed

Berichte: Bei Auswahl von mehreren Personen werden die "Soll Stunden" nicht korrekt angezeigt, wenn eine Person abwesend war #905

derTobsch opened this issue Oct 25, 2024 · 0 comments · Fixed by #922
Labels
status: planned This issue is planned in a milestone and won't be touched by stale bot. topic: report type: bug
Milestone
2.12.0

Comments

@derTobsch
Copy link
Contributor

derTobsch commented Oct 25, 2024 •
edited
Loading

Wenn man mehrere Personen auswählt und eine Person abwesend ist, zum Beispiel durch Urlaube oder Krankmeldungen, dann werden für alle Personen "Soll: 00:00" angezeigt. Sowohl in der Grafik

grafik

als auch in der Tagesansicht

grafik

Screencast.From.2024-10-25.15-57-19.mp4
@derTobsch derTobsch added status: new Initial state for every issue / pullrequest type: bug labels Oct 25, 2024
@derTobsch derTobsch added this to the 2.11.0 milestone Oct 25, 2024
@derTobsch derTobsch changed the title Berichte: Bei Auswahl von mehreren Personen wird soll nicht aufaddiert Berichte: Bei Auswahl von mehreren Personen werden die "Soll Stunden" nicht korrekt angezeigt Oct 25, 2024
@github-actions github-actions bot added status: planned This issue is planned in a milestone and won't be touched by stale bot. and removed status: new Initial state for every issue / pullrequest labels Oct 25, 2024
@derTobsch derTobsch changed the title Berichte: Bei Auswahl von mehreren Personen werden die "Soll Stunden" nicht korrekt angezeigt Berichte: Bei Auswahl von mehreren Personen werden die "Soll Stunden" nicht korrekt angezeigt, wenn eine Person abwesend war Oct 28, 2024
@derTobsch derTobsch modified the milestones: 2.11.0, 2.12.0 Oct 29, 2024
@github-actions github-actions bot added status: new Initial state for every issue / pullrequest status: planned This issue is planned in a milestone and won't be touched by stale bot. and removed status: planned This issue is planned in a milestone and won't be touched by stale bot. status: new Initial state for every issue / pullrequest labels Oct 29, 2024
honnel added a commit that referenced this issue Oct 29, 2024
@honnel
Make shouldWorkingHours implementation aware of multiple users
9dbf8f2 
fixes #905
@honnel honnel mentioned this issue Oct 29, 2024
Merged
5 tasks
honnel added a commit that referenced this issue Oct 29, 2024
@honnel
Make shouldWorkingHours implementation aware of multiple users
7378d10 
fixes #905
honnel added a commit that referenced this issue Oct 30, 2024
@honnel
Make shouldWorkingHours implementation aware of multiple users
5ed75e6 
fixes #905
honnel added a commit that referenced this issue Oct 30, 2024
@honnel
Make shouldWorkingHours implementation aware of multiple users
51a3cea 
fixes #905
derTobsch pushed a commit that referenced this issue Oct 31, 2024
@honnel @derTobsch
Make shouldWorkingHours implementation aware of multiple users
501d8d3 
fixes #905
derTobsch pushed a commit that referenced this issue Oct 31, 2024
@honnel @derTobsch
Make shouldWorkingHours implementation aware of multiple users
088715b 
fixes #905
derTobsch pushed a commit that referenced this issue Oct 31, 2024
@honnel @derTobsch
Make shouldWorkingHours implementation aware of multiple users
f2d8320 
fixes #905
derTobsch added a commit that referenced this issue Oct 31, 2024
@derTobsch
Make shouldWorkingHours implementation aware of multiple users (#922)
7ea85d4 
fixes #905

ToDos:

- [x] Additional test cases
- [x] Review other methods of report day to by aware of multiple users

Here are some things you should have thought about:

**Multi-Tenancy**
- [ ] ~~Extended new entities with `AbstractTenantAwareEntity`?~~
- [ ] ~~New entity added to `TenantAwareDatabaseConfiguration`?~~
- [x] Tested with `dev-multitenant` profile?

<!--

Thanks for contributing to the zeiterfassung.
Please review the following notes before submitting you pull request.

Please look for other issues or pull requests which already work on this
topic. Is somebody already on it? Do you need to synchronize?

# Security Vulnerabilities

🛑 STOP! 🛑 If your contribution fixes a security vulnerability, please do
not submit it.
Instead, please write an E-Mail to [email protected] with all the
information
to recreate the security vulnerability.

# Describing Your Changes

If, having reviewed the notes above, you're ready to submit your pull
request, please
provide a brief description of the proposed changes.

If they:
🐞 fix a bug, please describe the broken behaviour and how the changes
fix it.
    Please label with 'type: bug' and 'status: new'
    
🎁 make an enhancement, please describe the new functionality and why you
believe it's useful.
    Please label with 'type: enhancement' and 'status: new'
 
If your pull request relates to any existing issues,
please reference them by using the issue number prefixed with #.

-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: planned This issue is planned in a milestone and won't be touched by stale bot. topic: report type: bug
Projects
None yet
Milestone
2.12.0
Development

Successfully merging a pull request may close this issue.

Make shouldWorkingHours implementation aware of multiple users urlaubsverwaltung/zeiterfassung
2 participants
@bseber @derTobsch