Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Individuelle Abwesenheitsarten der Urlaubsverwaltung integrieren #425

Closed
bseber opened this issue Oct 28, 2023 · 1 comment · Fixed by #689
Closed

Individuelle Abwesenheitsarten der Urlaubsverwaltung integrieren #425

bseber opened this issue Oct 28, 2023 · 1 comment · Fixed by #689
Assignees
@bseber
Labels
status: planned This issue is planned in a milestone and won't be touched by stale bot. type: enhancement A general enhancement
Milestone
2.4.0

Comments

@bseber
Copy link
Contributor

bseber commented Oct 28, 2023 •
edited
Loading

Die Urlaubsverwaltung unterstützt ab demnächst individuellen Abwesenheitsarten.
Diese müssen wir in die Zeiterfassung integrieren.

TODOs:
@bseber bseber added the status: new Initial state for every issue / pullrequest label Oct 28, 2023
@github-actions github-actions bot added the status: stale Label for stale bot label Dec 29, 2023
@derTobsch derTobsch added this to the General Backlog milestone Dec 29, 2023
@derTobsch derTobsch removed the status: stale Label for stale bot label Dec 29, 2023
@github-actions github-actions bot added status: planned This issue is planned in a milestone and won't be touched by stale bot. and removed status: new Initial state for every issue / pullrequest labels Dec 29, 2023
@bseber bseber mentioned this issue May 10, 2024
Merged
1 task
@honnel honnel modified the milestones: General Backlog, 2.4.0 May 10, 2024
@github-actions github-actions bot added status: new Initial state for every issue / pullrequest status: planned This issue is planned in a milestone and won't be touched by stale bot. and removed status: planned This issue is planned in a milestone and won't be touched by stale bot. status: new Initial state for every issue / pullrequest labels May 10, 2024
@urlaubsverwaltung urlaubsverwaltung deleted a comment from github-actions bot May 13, 2024
@derTobsch derTobsch added the type: enhancement A general enhancement label May 16, 2024
@honnel
Copy link
Contributor

honnel commented May 17, 2024

Wir sollten ebenfalls die Local bzw den Fallback analog zu urlaubsverwaltung/urlaubsverwaltung#4660 bauen

honnel added a commit that referenced this issue May 17, 2024
@honnel
use up to date information for absence types (#689)
874caae 
closes #425 

- use `AbsenceType` translated label of external system, instead of hard
coded one
- use `AbsenceType` color from external system

---

Here are some things you should have thought about:

**Multi-Tenancy**
- ~~[ ] Extended new entities with `AbstractTenantAwareEntity`?~~
- ~~[ ] New entity added to `TenantAwareDatabaseConfiguration`?~~
- [x] Tested with `dev-multitenant` profile?

<!--

Thanks for contributing to the zeiterfassung.
Please review the following notes before submitting you pull request.

Please look for other issues or pull requests which already work on this
topic. Is somebody already on it? Do you need to synchronize?

# Security Vulnerabilities

🛑 STOP! 🛑 If your contribution fixes a security vulnerability, please do
not submit it.
Instead, please write an E-Mail to [email protected] with all the
information
to recreate the security vulnerability.

# Describing Your Changes

If, having reviewed the notes above, you're ready to submit your pull
request, please
provide a brief description of the proposed changes.

If they:
🐞 fix a bug, please describe the broken behaviour and how the changes
fix it.
    Please label with 'type: bug' and 'status: new'
    
🎁 make an enhancement, please describe the new functionality and why you
believe it's useful.
    Please label with 'type: enhancement' and 'status: new'
 
If your pull request relates to any existing issues,
please reference them by using the issue number prefixed with #.

-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bseber bseber

Labels
status: planned This issue is planned in a milestone and won't be touched by stale bot. type: enhancement A general enhancement
Projects
None yet
Milestone
2.4.0
Development

Successfully merging a pull request may close this issue.

use up to date information for absence types urlaubsverwaltung/zeiterfassung
3 participants
@honnel @bseber @derTobsch