do not override already provided methods

CrudRepository is provided by spring data and methods are learned by developers.

src/main/java/de/focusshift/zeiterfassung/settings/FederalStateSettingsRepository.java

@@ -2,8 +2,5 @@
 
 import org.springframework.data.repository.CrudRepository;
 
-import java.util.List;
-
 interface FederalStateSettingsRepository extends CrudRepository<FederalStateSettingsEntity, Long> {
-    List<FederalStateSettingsEntity> findAll();
 }

src/main/java/de/focusshift/zeiterfassung/settings/SettingsService.java

@@ -5,6 +5,8 @@
 
 import java.util.Optional;
 
+import static java.util.stream.StreamSupport.stream;
+
 @Service
 class SettingsService implements FederalStateSettingsService {
 
@@ -40,6 +42,9 @@ FederalStateSettings updateFederalStateSettings(FederalState federalState, boole
     }
 
     private Optional<FederalStateSettingsEntity> getFederalStateEntity() {
-        return federalStateSettingsRepository.findAll().stream().findFirst();
+        // `findFirst` is sufficient as there exists only one FederalStateSettingsEntity per tenant.
+        // however, the tenantId is handled transparently in the background. and we only have the public API of `findAll`.
+        final Iterable<FederalStateSettingsEntity> settings = federalStateSettingsRepository.findAll();
+        return stream(settings.spliterator(), false).findFirst();
     }
 }