Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webtalk on moons #49

Open
Fang- opened this issue Mar 24, 2018 · 3 comments
Open

Webtalk on moons #49

Fang- opened this issue Mar 24, 2018 · 3 comments
Labels

Comments

@Fang-
Copy link
Member

Fang- commented Mar 24, 2018

When loading webtalk off a moon, it tries to load from the moon's Hall. Since moons use their planet's Hall, there's nothing there, so no messages ever load. It should be sending subscriptions to the planet instead.

@Fang- Fang- added the bug label Mar 24, 2018
@Fang- Fang- self-assigned this Mar 24, 2018
@xykj61
Copy link

xykj61 commented Apr 11, 2018

It'd be sweet if this got fixed.

@Fang- Fang- removed their assignment Apr 11, 2018
@Fang-
Copy link
Member Author

Fang- commented Apr 11, 2018

So apparently you can't just be lazy about it and window.urb.ship = planet if ship is moon at the top of the js and have that work. Like, it loads the messages, but sending seems broken.

Unassigned myself because eth work, but I could take a stab at this over the weekend maybe. Really it's probably just changing the urb.bind parameters to target the planet, but I'll have to dive deeper to remember how that worked exactly.

@Fang-
Copy link
Member Author

Fang- commented Apr 11, 2018

Also I guess cc @c-johnson to take this into account for Collections. Maybe in the future moons will provide actual functional mirrors of their planet's hall (they probably should) but for now you want to take care here not to talk to moons when doing hall stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants