Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No distinction between normal messages and hoon eval #23

Open
ohAitch opened this issue Jun 20, 2016 · 4 comments
Open

No distinction between normal messages and hoon eval #23

ohAitch opened this issue Jun 20, 2016 · 4 comments

Comments

@ohAitch
Copy link
Contributor

ohAitch commented Jun 20, 2016

This is exacerbated by the static heights completely hiding the eval results, which do have code-block styling.

@ohAitch ohAitch changed the title No distinction between normal messages and goo eva No distinction between normal messages and hoon eva Jun 20, 2016
@ohAitch ohAitch changed the title No distinction between normal messages and hoon eva No distinction between normal messages and hoon eval Jun 20, 2016
@galenwp
Copy link
Contributor

galenwp commented Jul 14, 2016

I think @knubie fixed the static heights problem — so we should be able to put in (at least some) of the result in as well. @knubie, right?

@knubie
Copy link
Contributor

knubie commented Jul 14, 2016

Are we talking about moving the eval results outside of hover and putting them directly in the messages list? As long as the height is known, it shouldn't be a problem. Maybe a show/hide toggle would be better, as some of the results are quite long.

I suppose the main problem here is that hoon eval messages are not styled differently enough. Maybe add a background color #f7f7f7 like the way markdown renders code blocks.

@galenwp
Copy link
Contributor

galenwp commented Jul 14, 2016

On hover (I think) they appear inside of a fixed-height div that has overflow: scroll. I'd be open to a background color. They do appear in monospace.

@ohAitch
Copy link
Contributor Author

ohAitch commented Jul 14, 2016

I like the "use the same code class as tree" idea.

They do appear monospace, but that's still visually confusing for e.g. .

On Thursday, 14 July 2016, Galen Wolfe-Pauly [email protected]
wrote:

On hover (I think) they appear inside of a fixed-height div that has overflow:
scroll. I'd be open to a background color. They do appear in monospace.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#23 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/ABxXhh5En_MAjz2i2bjGNFwTCoA8MBvbks5qVmlsgaJpZM4I5VaB
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants